One of my buddies was using your PLD.lua last night, and we were trying to figure out how defense sets work.
I notice you have sets for things like sets.defense.MDT.HP and sets.defense.MDT.Reraise, but they don't ever get used.
Were you planning on implementing these sets with CustomDefenseGroups? If so, I'd be curious how you would handle that. I figured you intended these to work similarly to something like sets.engaged.Acc.PDT, where you can be in two different modes, and get a unique set as a result. It doesn't look like defensive modes consider anything else though. (besides custom groups)
I was trying to add Repulse Mantle to both PhysicalDefenseMode and MagicalDefenseMode, but couldn't figure out the set logic. If I created a toggle for those groups called "Repulse", the only set that works for either is sets.defense.Repulse. I need something like sets.defense.MDT.Repulse and sets.defense.PDT.Repulse
I can think of a few ways to get this working, but none seem by design. I could make modes for PDTRepulse and MDTRepulse, or I could add "Repulse" to options.DefenseModes, and then query that in job_status_change, etc.
Code:
classes.CustomDefenseGroups:clear()
if state.DefenseMode == 'Repulse' then
classes.CustomDefenseGroups:append('Repulse')
end