Gearswap Help Thread!

**nikia** · 2014-06-04 22:36

Wanted to see if Anyone has wrote in creation of timers for mythic and empy Aftermath 1,2,3?

Looking for when say aftermath 3 buff is gained with mythic an onscreen timer would count down reaming time.
I know I saw someone with it coded in few months ago but I cant recall where.
Tried to figure it out on my own but unclear on the best way to handle the creation and since empy and mythic aftermath times are different if there was a universal rule that would cover either.
Any help would be welcomed.
Thank you.

**shepardG** · 2014-06-05 04:56

https://github.com/ShepardG/FFXI-Gearswap

So here's my current GEO lua file. It's not pretty, and i'm missing some melee stuff, but it's pretty much Mote's file, with some stuff added in that i basically pieced together from his documentation and other GS's.

Was hoping to get some pointers on what isn't functioning, or what is just spaghetti. It seems to be working decently in game, but I'm sure i made some mistakes, and have wasted/unused sets/rules/etc.
Any pointers would be appreciated, and thanks Mote for making this game bearable to play lol. You need a paypal button.

After ya'll school me, i'll make the changes and then see if it can be published to in the GS directory file for others to use.
v/r

**Julian** · 2014-06-05 05:16

Originally Posted by JSHidaka

I was thinking more, after you determine that there is a sc, just set a variable with the element(a variable that will reset for the time the Mb windows is open) then if you cast an spell, check if it will MB(with the element you got in the variable) if not change spell to one that will.

And wasn't thinking about packets, was more an event that activate with text.

I now in paper "works", in practice, no idea, I'm not that lazy to need something like that.

That wouldn't be too difficult to do. Skillchains should be mapped somewhere on the action packet in the wiki. Just write an event for it in your gearswap and it should work.

(I think, anyway. )

**DynastyEmperor** · 2014-06-05 05:32

Hi, I'm new to Gearswap

I've managed to work out my BRD lua but for the life of me I can't seem to be my SCH lua to work. It's basically the one from Kinematics with some tweaks.
It seems to handle sublimation gear swapping well but it doesn't swap for anything else like cures/nukes/helix etc.

Any help would be greatly appreciated!

Spoiler: show

**Sechs** · 2014-06-05 15:26

Something new happened to me for the first time.
I have an in-game macro with:
/ja Nightingale
/wait 1
/ja Troubadour

For the first time Gearswap didn't precast correctly the body for Troubadour, with the result that Nightingale lasted 30 seconds more.
It never happened before to me. What could the cause be? Lag? Something else?
Want to check the code maybe to see if something can be improved/changed in that regard?

http://pastebin.com/GX1Yiyv9

**Byrthnoth** · 2014-06-05 15:54

Did you upgrade your body to +1 recently?

**Sechs** · 2014-06-05 16:05

Nope, working good. In these 2 runs I used that macro 6 times and it happened only once.
I didn't touch the Lua or anything.

**Byrthnoth** · 2014-06-05 16:07

Hmm... don't know then.

**JSHidaka** · 2014-06-05 16:31

now after the update... sometimes(in dinamis atm).. I press my WS macro.. and It only boost... the WS doesnt go... found the problem I need the function buff_change(status,gain_or_loss) for this to work auto.. and using debugmode
Is buffgain/lost not triggering for boost...

**Motenten** · 2014-06-05 16:54

I'm actually going to make some changes on my state.Buff tracking code. Instead of not making any assumption about the buff until aftercast is run, and then setting based on spell.interrupted, I was going to set state.Buff to true on precast, and then reevaluate it based on spell.interrupted on aftercast. There's some instances where I'm not completely sure aftercast is being hit before the next action.

Basically, this is just a more paranoid version of the conversion from buff_change checks to aftercast checks, but instead of "set to true when we -know- the buff is present, rather than waiting for notification", it's "assume it's true by default, and then adjust when we know whether it's true or not".

As for your question, JSHidaka -- well, I really don't understand the question. I see buff_change called when I use Boost. The rest of the question doesn't really make sense.

**Sechs** · 2014-06-05 16:54

Originally Posted by Byrthnoth

Hmm... don't know then.

Supposing there's nothing wrong in the LUA I wrote then can we hypothize a very bad lagspike at the wrong moment?

**JSHidaka** · 2014-06-05 16:58

Originally Posted by Motenten

I'm actually going to make some changes on my state.Buff tracking code. Instead of not making any assumption about the buff until aftercast is run, and then setting based on spell.interrupted, I was going to set state.Buff to true on precast, and then reevaluate it based on spell.interrupted on aftercast. There's some instances where I'm not completely sure aftercast is being hit before the next action.

Basically, this is just a more paranoid version of the conversion from buff_change checks to aftercast checks, but instead of "set to true when we -know- the buff is present, rather than waiting for notification", it's "assume it's true by default, and then adjust when we know whether it's true or not".

As for your question, JSHidaka -- well, I really don't understand the question. I see buff_change called when I use Boost. The rest of the question doesn't really make sense.

http://i93.photobucket.com/albums/l5...605_175637.png

well it doesn't for me. and there is no more updates, probably you are in -Dev, I'm not.

**sydok** · 2014-06-05 17:02

Originally Posted by Motenten

I'm actually going to make some changes on my state.Buff tracking code. Instead of not making any assumption about the buff until aftercast is run, and then setting based on spell.interrupted, I was going to set state.Buff to true on precast, and then reevaluate it based on spell.interrupted on aftercast. There's some instances where I'm not completely sure aftercast is being hit before the next action.

Basically, this is just a more paranoid version of the conversion from buff_change checks to aftercast checks, but instead of "set to true when we -know- the buff is present, rather than waiting for notification", it's "assume it's true by default, and then adjust when we know whether it's true or not".

As for your question, JSHidaka -- well, I really don't understand the question. I see buff_change called when I use Boost. The rest of the question doesn't really make sense.

I know if I pianissimo then sing very quickly, it won't use target change rules that check if pianissimo is active. My current work around is to activate a pianissimo variable toggle in my pianissimo macro and check that value instead.

**JSHidaka** · 2014-06-05 17:09

and other "buff" are bypassing randomly the "buff_change"... Regen 5, Enfire, Protect V, sometimes works others doesn't... so something is broken w/ the new luacore

EDIT...

Luacore just got updated.. and everything looks "normal"

**Byrthnoth** · 2014-06-05 17:23

Yeah, Arcon reverted it. He is trying to update LuaCore so that the buff_gain and buff_loss events fire even when you gain or lose a buff that you already have.

**Motenten** · 2014-06-05 18:34

Originally Posted by nikia

Wanted to see if Anyone has wrote in creation of timers for mythic and empy Aftermath 1,2,3?

Looking for when say aftermath 3 buff is gained with mythic an onscreen timer would count down reaming time.
I know I saw someone with it coded in few months ago but I cant recall where.
Tried to figure it out on my own but unclear on the best way to handle the creation and since empy and mythic aftermath times are different if there was a universal rule that would cover either.
Any help would be welcomed.
Thank you.

I've built this in my utilities include. It should work for any REM weapon, though it assumes mythics are at least level 80.

It's been pushed to my Mote-libs repository, but not pushed to the general Windower launcher update. If you want to test it out, get the latest Mote-Mappings and Mote-Utility, and then add the following function calls to your job_precast and job_aftercast functions:

Code:

function job_precast(spell, action, spellMap, eventArgs)
	custom_aftermath_timers_precast(spell)
end

function job_aftercast(spell, action, spellMap, eventArgs)
	custom_aftermath_timers_aftercast(spell)
end

**Motenten** · 2014-06-05 18:50

Originally Posted by beaute

The hash is: TMjLkjLj
What part of the include(s) is relevant to job abilities? I could try to debug it if I knew where to start.

OK, I've reviewed your file several times, and still can't find anything wrong.

For debugging, I'd start by adding add_to_chat() functions in job_precast() and job_post_precast(). Make sure they're getting called, and that the spell information is correct (try print_set(spell, 'spell')). Add additional checks in job_aftercast() to see if it's reaching there, and that the spell completed. Expand beyond that based on the information you find.

If all else fails, make sure you've run the launcher and are fully updated, and then download a fresh copy of the thf lua file. Make a sidecar (thf_gear.lua) file, and put all your gear changes in that. (See documentation on sidecar files.)

**fingleburt** · 2014-06-05 22:58

Hi,

I'm pretty new to gearswap, used to use spellcast so my lack of lua knowledge isn't too good. With my mnk.xml I used to be able to lock my body to Tantra Cyclas +2 for the duration of Impetus, the code used to look like this:

Code:

<if buffactive="Impetus">
            <equip when="all">
            <body lock="yes">Tantra Cyclas +2</body>
            </equip>
        </if>

Then I would have Autoexe kick in with:

Code:

<register event="gainbuff_Impetus" silent="true">sc set Impetus</register></register>

And then:

Code:

<register event="losebuff_Impetus" silent="true">sc set Engaged</register>

Which would switch my body back to my tp body.
Is there anyway to replicate this with gearswap?

I've tried this:

Code:

function buff_change(status,gain_or_loss)
    if status == "Impetus" then
		if gain_or_loss then
			equip(sets.TP.Impetus)
			send_command('@wait .5;gs disable body')
            add_to_chat(121,'>!===EQUIPPING TANTRA CYCLAS +2===!<')			
        else
			send_command('gs enable body')
            add_to_chat(121,'>!===IMPETUS DOWN===!<')
            equip(sets.TP)			
		end
    end
end

This works in a sense to lock the body during Impetus which is great, however I cannot get it to equip my Impetus down set. If I take

Code:

send_command('@wait .5;gs disable body')

code away it reverts back to Impetus down set but of course it wont lock the body during Impetus.
I should clarify that I'm using a very simple lua file with no includes etc.

I would be grateful for any help/suggestions.

**nikia** · 2014-06-05 22:59

Originally Posted by Motenten

I've built this in my utilities include. It should work for any REM weapon, though it assumes mythics are at least level 80.

It's been pushed to my Mote-libs repository, but not pushed to the general Windower launcher update. If you want to test it out, get the latest Mote-Mappings and Mote-Utility, and then add the following function calls to your job_precast and job_aftercast functions:

Code:

function job_precast(spell, action, spellMap, eventArgs)
	custom_aftermath_timers_precast(spell)
end

function job_aftercast(spell, action, spellMap, eventArgs)
	custom_aftermath_timers_aftercast(spell)
end

Thanks for posting I looked it over and it gave me an idea, wanted to run it past you please.
I tend to shy away from includes since I only really play 4 jobs and anything commonly shared I can just easily adjust across 4 files.
So with that in mind I wanted to bake the logic into individual files, this is what I came up with, any input would be nice.

So gaining/losing buff will be the handle for timer creation and deletion.

Code:

function buff_change(buff,g_or_l)
    -- Used with Timers Plugin to create and delete custom timers for aftermath leverls
    if buff == 'Aftermath: Lv.1' and player.equipment.main == 'Twashtar' and g_or_l == true then
        send_command('timers c "Aftermath: Lv.1" 30 down abilities/00027.png')
    elseif buff == 'Aftermath: Lv.2' and player.equipment.main == 'Twashtar' and g_or_l == true then
        send_command('timers c "Aftermath: Lv.2" 60 down abilities/00027.png')
    elseif buff == 'Aftermath: Lv.3' and player.equipment.main == 'Twashtar' and g_or_l == true then
        send_command('timers c "Aftermath: Lv.3" 90 down abilities/00027.png')
    end
    if buff == 'Aftermath: Lv.1' and player.equipment.main == 'Twashtar' and g_or_l == false then
        send_command('timers d "Aftermath: Lv.1"')
    elseif buff == 'Aftermath: Lv.2' and player.equipment.main == 'Twashtar' and g_or_l == false then
        send_command('timers d "Aftermath: Lv.2"')
    elseif buff == 'Aftermath: Lv.3' and player.equipment.main == 'Twashtar' and g_or_l == false then
        send_command('timers d "Aftermath: Lv.3"')
    end
end

In Precast this will re-create the Lv1 timer since that can overwrite itself.

Code:

    -- Since Aftermath: Lv.1 can overwrite itself this will delete and re-create this specific timer
    if spell.name == 'Rudra\'s Storm' and player.equipment.main == 'Twashtar' and player.tp < 200 and player.tp > 100 and buffactive['Aftermath: Lv.1'] then
        send_command('timers d "Aftermath: Lv.1"')
        send_command('timers c "Aftermath: Lv.1" 30 down abilities/00027.png')
    end

The above was tested on a friends DNC.lua and seems to work fine, I added the player.equipment.main check to determine if empy or mythic aftermath.

Does this seem like a decent(hopefully well formed) way of doing the call/logic?
If it is well formed I will just expand as needed.

Thank you for your time, I am grateful.

**Motenten** · 2014-06-06 00:13

Originally Posted by nikia

I tend to shy away from includes since I only really play 4 jobs and anything commonly shared I can just easily adjust across 4 files.

I code with the principal that if it's possible for code to be shared, it ought to be refactored, and if it can be shared by multiple (ie: more than 1) files, it ought to be in an include.

Originally Posted by nikia

So gaining/losing buff will be the handle for timer creation and deletion.

That works well for Empys and Mythics, but fails with Relics because Relic aftermath duration scales with TP, rather than only being tied to the specific tier.

It also would fail in the edge case of a sam with Mura+Yoichi, since it doesn't identify whether it's a Mythic or Relic aftermath.

However, if you know neither of those will be the case, can skip past that issue.

Originally Posted by nikia

Code:

function buff_change(buff,g_or_l)
    -- Used with Timers Plugin to create and delete custom timers for aftermath leverls
    if buff == 'Aftermath: Lv.1' and player.equipment.main == 'Twashtar' and g_or_l == true then
        send_command('timers c "Aftermath: Lv.1" 30 down abilities/00027.png')
    elseif buff == 'Aftermath: Lv.2' and player.equipment.main == 'Twashtar' and g_or_l == true then
        send_command('timers c "Aftermath: Lv.2" 60 down abilities/00027.png')
    elseif buff == 'Aftermath: Lv.3' and player.equipment.main == 'Twashtar' and g_or_l == true then
        send_command('timers c "Aftermath: Lv.3" 90 down abilities/00027.png')
    end
    if buff == 'Aftermath: Lv.1' and player.equipment.main == 'Twashtar' and g_or_l == false then
        send_command('timers d "Aftermath: Lv.1"')
    elseif buff == 'Aftermath: Lv.2' and player.equipment.main == 'Twashtar' and g_or_l == false then
        send_command('timers d "Aftermath: Lv.2"')
    elseif buff == 'Aftermath: Lv.3' and player.equipment.main == 'Twashtar' and g_or_l == false then
        send_command('timers d "Aftermath: Lv.3"')
    end
end

Somewhat redundantly built. I'd rework it as:

Code:

function buff_change(buff, gain)
    -- Used with Timers Plugin to create and delete custom timers for aftermath levels
    if player.equipment.main == 'Twashtar' and buff:startswith('Aftermath') then
        local times = {["Aftermath: Lv.1"]=30, ["Aftermath: Lv.2"]=60, ["Aftermath: Lv.3"]=90}
        
        if gain then
            send_command('timers c "'..buff..'" '..tostring(times[buff])..' down abilities/00027.png')
        else
            send_command('timers d "'..buff..'"')
        end
    end
end

Generally, you do not want to check the same condition more than once. I'd probably also try to move the 'times' table to a higher scope (such as file initialization) so it doesn't have to be recreated every time through this function.

In Precast this will re-create the Lv1 timer since that can overwrite itself.

Workable as long as you ignore issues of failed weaponskills (out of range, slept, stunned, etc).

Thread: Gearswap Help Thread!

Thread Tools

Similar Threads

Spellcast Help Thread (Link your XML using Pastebin.com for help!)

Latest Threads

Up & Coming Threads

Hottest Threads