Gearswap Help Thread!

[geno3302]

There's a bug with the pet_status_change function in gearswap.
Inside the gearswap.lua file in the function that handles incoming chunk, in the section that handles 0x0E (line 308.)
When an avatar auto-engages (you get aggro) or when a monster dies and the avatar auto-disengages as well as most of the time when you use assault for the first time on a monster the pet.status in like 309 is updated before gearswap handles the packet so the oldstatus is always equal to the new status and the pet_status_change event is never fired.

pet.status is taken from the windower api, it is the value from the mob table, and it is always up to date and correct.

I did a test to make oldstatus a global and made it persist the old value of newstatus, I also added an add_to_chat statement to see when the 0x0E chunk actually gets processed.

Doing this does fix it so the function will always be called however the chunk with ID 0x0E seems to be very random. It will always eventually update however it can take upwards of 10 seconds after a monster dies for it to actually trigger. During that window the pet.status will report the correct values so there must be some issue with the processing of that packet or the windower api is getting the value from elsewhere.

[KLoOoSH]

on your whm issue
the main issue is that you have no precast set for Cursna so it defaults to the fast cast set and in midcast you have Cursna in your na rules so it will never equip the midcast Cursna set on line 511
if you remove it from here you will never equip your na set when using Cursna but if you dont it will never equip your Cursna set
but you can add

 if spell.english == "Cursna" then
                equipSet = set_combine(equipSet,sets.Midcast.Cursna)
            end

at line 514 and it should fix most of your issues

to fix the thf issue remove lines 318 - 323
this is most likely causing your issue because if you try to use Sneak Attack or Trick Attack and it gets stopped you have no way to turn them off unless you use them again
but you also have code in your buff_change function so its not needed in your precast function

if you still want me to rewrite you files i can but it wont be for almost 3 days i have to head out of town

i did what u said and everything worked fine just 1 thing Divine Caress Set when i do JA "Divine Caress" it doesn't swap to -- Divine Caress Set --
sets['Divine Caress'] = {
main="Yagrush",
hands="Orison Mitts +2",
back="Mending Cape"}
Only the Yagrush swap alone but the Hands,Back doesn't swap

[KLoOoSH]

Here is my WHM gearswap:
pastebin.com/v1FgQ7fn

Please help me out

sets['Divine Caress'] = {
main="Yagrush",
hands="Orison Mitts +2",
back="Mending Cape"}

[Nameless]

use this
elseif spell.english == "Third Eye" and windower.ffxi.get_ability_recasts()[139] < 1 and not buffactive.Seigan then

This works wonderfully. Thank you and those who helped. Just for my own understanding, why does it loop like it did before? Is it that particular line or perhaps it is something else in my file that was causing that?

[Sechs]

Not sure if this might be linked to the bug Geno found out, but I experienced a very bizarre behaviour from Gearswap on SMN, over the last few days, after implementing a change in my lua.
I added a custom function to create custom timers in the "Custom" box of Timers (plugin) so that I can track stuff like Hastega2, Crystal Blessing etc.
Sometimes, for no appearent reason, stuff doesn't get tracked. Most of the time it works, but sometimes some custom timers just do not get created.
Here following the part of the code I used in my Lua, which you can see entirely HERE.

Maps:
In this part I created a custom map, it's used to handle the timer creating function, which is the same regardless of the BP I "feed" to the function.

Spoiler: show

	buffs_maps = {['Hastega II']=378, ['Crystal Blessing']=378, ['Crystalline Blessing']=378, ['Crimson Howl']=258, ['Inferno Howl']=258, ['Fleet Wind']=320, ['Earthen Armor']=258, ['Ecliptic Growl']=378, ['Ecliptic Howl']=378}

Function:
This is the custom function itself. I feed it with a BP name, and it creates a custom timer according to the table above.

Spoiler: show

function custom_buff_timers(spell)
	local ctimer = buffs_maps[spell]
	send_command('timers c "'..spell..'" '..tostring(ctimer)..'')
end

Aftercast:
In this function I call my custom one. Ignore the first part and check the second "If", which is the one I added recently.

Spoiler: show

function pet_aftercast(spell,action)
	if pet.isvalid then
		if not buffactive['Astral Conduit'] then
			equip(sets.idle.avatar[petmode])
		end
	else
		equip(sets.idle)
	end
	if buffs_maps[spell.english] then
		custom_buff_timers(spell.english)
	end
end

Now from all of this, which is pretty simple, can you see any error I made to justify the fact that sometimes timers do not get created? Or is it an issue with the bug Geno reported above?

[Byrthnoth]

If you move 30' from your avatar before the BP goes off, you won't receive an action packet indicating the action has completed and thus it won't call aftercast (and you won't make a timer).

[Sechs]

If you move 30' from your avatar before the BP goes off, you won't receive an action packet indicating the action has completed and thus it won't call aftercast (and you won't make a timer).

That's good to know, but I was in a CP pt in bats room and 99,9% sure the Avatar was standing right beside me.
It was just random.
If there's no error in my code then I dunno what to think, other than a packet loss or something.

[blado]

Is there built in functionality for adding additional items for validate to check? For example, I'd like to make a sets.additional_items = {"Toolbag (Shihe)"} in my nin.lua.

I can fake it by doing sets.additional_items = {head="Toolbag (Shihe)"} which works, but obviously is not ideal.

[dlsmd]

I copied your suggestion and pasted it into my file and gave it a try, but unfortunately it didn't work - thanks for trying, though!

It's annoying because it's just songs that are being uncooperative. I have healing macros that use Shortcuts and are just /cure4, for example - if I don't target anything, I cast Cure IV on myself, and if I target another player, it casts Cure IV on them. Doing the same with songs and a macro like /valorminuet5 works in the sense that I can sing without having to target myself, but if I then use Pianissimo and target someone else, I still cast on myself.

use this
if spell.type == 'BardSong' and spell.targets == 'Self' and spell.target.raw == '<t>' and not buffactive.Pianissimo then
and change_target('<me>') will only work in the pretarget function

Is there built in functionality for adding additional items for validate to check? For example, I'd like to make a sets.additional_items = {"Toolbag (Shihe)"} in my nin.lua.

I can fake it by doing sets.additional_items = {head="Toolbag (Shihe)"} which works, but obviously is not ideal.

nope

This works wonderfully. Thank you and those who helped. Just for my own understanding, why does it loop like it did before? Is it that particular line or perhaps it is something else in my file that was causing that?

because you were not checking for recast of seigen while the one i posted does

i did what u said and everything worked fine just 1 thing Divine Caress Set when i do JA "Divine Caress" it doesn't swap to -- Divine Caress Set --
sets['Divine Caress'] = {
main="Yagrush",
hands="Orison Mitts +2",
back="Mending Cape"}
Only the Yagrush swap alone but the Hands,Back doesn't swap

are you sure that you have thoes items in eather your gobbie bag or wardrobe
but you could try it like this

        if Na_Spells:contains(spell.english) then
            equipSet = equipSet.Na
            add_to_chat(158, '************* ['..spell.name..'] ************')
            if spell.english == "Cursna" then
                equipSet = set_combine(equipSet,sets.Midcast.Cursna)
            end
            if DC then
                equipSet = set_combine(equipSet,sets['Divine Caress'])
            end

[Trumpy]

If you are using the showswaps feature it wont show any equip changes if you are already wearing that item as well.

[dlsmd]

If you are using the showswaps feature it wont show any equip changes if you are already wearing that item as well.

i for got about that one

[KLoOoSH]

are you sure that you have thoes items in eather your gobbie bag or wardrobe
but you could try it like this

        if Na_Spells:contains(spell.english) then
            equipSet = equipSet.Na
            add_to_chat(158, '************* ['..spell.name..'] ************')
            if spell.english == "Cursna" then
                equipSet = set_combine(equipSet,sets.Midcast.Cursna)
            end
            if DC then
                equipSet = set_combine(equipSet,sets['Divine Caress'])
            end

I just tried this but it didnt work ; ;
Yes, am sure i have them in my Mog Wardrobe

[KLoOoSH]

If you are using the showswaps feature it wont show any equip changes if you are already wearing that item as well.

No, am not wearing them
ty

[dlsmd]

I just tried this but it didnt work ; ;
Yes, am sure i have them in my Mog Wardrobe

you are talking about midcast and not precast correct
it its because your not equiping the correct gear precast that would be because you do not have a precast gearset setup for Cursna

[Sechs]

That's good to know, but I was in a CP pt in bats room and 99,9% sure the Avatar was standing right beside me.
It was just random.
If there's no error in my code then I dunno what to think, other than a packet loss or something.

^ 100%, re-tested

Think I *might* have found the source of the issue.
I think it happens when a timer is already present.
For example if the "Hastega II" timer attempts to get created when there are still a few seconds left on the previous one, the new timer won't be created, the old one will expire and you won't see any timer in the Custom list.

Could this be the reason? Just an hypothesys...

nevermind, this is not the cause.

[KLoOoSH]

you are talking about midcast and not precast correct
it its because your not equiping the correct gear precast that would be because you do not have a precast gearset setup for Cursna

no am not talking about Cursna am talking about WHM Job Ability 'Divine Caress', cursna problem already solved
when i do JA 'Divine Caress' it should swap to -- Divine Caress Set -- But its not swapping.

-- Divine Caress Set --
sets['Divine Caress'] = {
main="Yagrush",
hands="Orison Mitts +2",
back="Mending Cape"}


http://pastebin.com/v1FgQ7fn

[Byrthnoth]

nevermind, this is not the cause.

Do you know that pet_aftercast function is not getting called in these cases? If that's the case and you're also seeing the "Garuda uses Hastega II" message (which indicates that the action packet isn't dropped) then it's a bug with gearswap.

[Sechs]

I could add a check like an add_to_chat message to see if pet_aftercast gets called or not. But afaik I always return to my idle gear, and since that check happens in the pet_aftercast function, I'm leaning to say the pet_aftercast function *does* get called every time.
Regardless, it's worth checking more.
Next time I'll go CPing on SMN I'll try to add a chatline check and to be more focused.


edit:
Created three chat lines: one for when the Pet_aftercast function starts, one for when the buffs_maps check succeeds, one for when the custom_buffs_timers function starts.
If when the "no timer" issue occcurs one or more of these 3 chat lines will be missing, they'll tell us a lot about where/when the error occurs.
If they'll all appear instead I'll be left pretty clueless instead lol

[Byrthnoth]

Yeah, if the all appear then the problem is in your user file.

Make sure you print out spell.name

[Martel]

no am not talking about Cursna am talking about WHM Job Ability 'Divine Caress', cursna problem already solved
when i do JA 'Divine Caress' it should swap to -- Divine Caress Set -- But its not swapping.

-- Divine Caress Set --
sets['Divine Caress'] = {
main="Yagrush",
hands="Orison Mitts +2",
back="Mending Cape"}


http://pastebin.com/v1FgQ7fn

DC gear isn't supposed to be equipped on JA use. It's supposed to be on when you cast a na spell with DC active.

That being said, that lua still has two issues.

#1 Buff_change takes a few seconds to register. If you hit DC then immediately na, most of the time the change won't have applied soon enough. And you'll jsut use normal Na gear rather than DC gear.

Generally have to put the variable trigger on the use of the JA, with a recast check so it doesn't change it if it can't be used.

#2 I don't see anything that turns the DC variable back off so after the first DC use it should get stuck on.