Gearswap Help Thread!

[Yamoman]

i see that mote-utility lua has the function to cancel sneak for ichi or spectral jig before recast to avoid no effect, how do i enable that in job luas? doin AAs on mnk, and would be a lil faster on shadows if i didnt have to manually cancel sneak. thx in advance

[Motenten]

Hey mote, im trying to build a runefencer GS using your functionality. What would be the best existing GS you have? Initially I thought DNC, but I think Pld with a modified steps cycle keybind added from your DNC lua would suit RUN better.
If I approach that tonight when I get home, would I need to update any of your universal luas as well?
So id have the core of pld but the cyclic functionality of cycling through runes with your key binds

Ideally, use template.lua and just reference the others for the things you want to do, and delete the stuff you don't need. That way you end up with a file that only has exactly what you need, and you know why everything's there.

You should never need to modify any of the Mote-* files. Modifying them means you understand what you're doing well enough that you don't need to ask me what to do or not do.

[Motenten]

real quick id like to just point out in the smn.lua; 'thunderstorm' is listed correctly in the BP Variables in the top in all however I'm not experiencing any gearswappage taking place on that particular BP

If someone could go test it out, i think theres a bug or something with that particular BP; I change nothing code-wise on these lua's just gear

Most likely it's ambiguity between the smn pact Thunderstorm and the sch weather spell Thunderstorm. If GearSwap provides info indicating the sch storm version, the code will never correctly identify which gear sets to use. I'd need to test it to be sure.

Edit: Tested and it's not that. Seeing what else might be the problem.

Edit: Well, sort of. GearSwap's spell parameter provides the correct information. The problem is that the spell mapping from Mote-Mappings maps Thunderstorm to the Storm line of spells.

A small fix to Mote-Include will correct the issue. I'll push it in a bit.

[shepardG]

Ideally, use template.lua and just reference the others for the things you want to do, and delete the stuff you don't need. That way you end up with a file that only has exactly what you need, and you know why everything's there.

You should never need to modify any of the Mote-* files. Modifying them means you understand what you're doing well enough that you don't need to ask me what to do or not do.

Tou che' ill give it a shot, I didnt even know thst existed

[Motenten]

i see that mote-utility lua has the function to cancel sneak for ichi or spectral jig before recast to avoid no effect, how do i enable that in job luas? doin AAs on mnk, and would be a lil faster on shadows if i didnt have to manually cancel sneak. thx in advance

Add this line:

	cancel_conflicting_buffs(spell, action, spellMap, eventArgs)

to the job_precast() function.

[Sechs]

Edit:

[Sechs]

If someone is particularly bored and wants to give a look at this Lua I would apreciate!
http://pastebin.com/vRpzfnhU

Fixed some things in the /echo messages under the Self_command section as some of them weren't working.
I just finished tanking Kumhau, everything seemed to be working as far as I could tell within all that massive lag.

[dlsmd]

If someone is particularly bored and wants to give a look at this Lua I would apreciate!
http://pastebin.com/vRpzfnhU

Fixed some things in the /echo messages under the Self_command section as some of them weren't working.
I just finished tanking Kumhau, everything seemed to be working as far as I could tell within all that massive lag.

looks good to me

[JSHidaka]

If someone is particularly bored and wants to give a look at this Lua I would apreciate!
http://pastebin.com/vRpzfnhU

Fixed some things in the /echo messages under the Self_command section as some of them weren't working.
I just finished tanking Kumhau, everything seemed to be working as far as I could tell within all that massive lag.

the only thing Im not sure are:

--Midcast sets
        sets.midcast = {}
        sets.midcast['Enhancing Magic'] = {neck="Colossus's torque", hands="Runeist mitons", waist="Olympus Sash", legs="Futhark Trousers"}
        sets.midcast['Phalanx'] = set_combine(sets.midcast['Enhancing Magic'], {head="Futhark Bandeau"})
        sets.midcast['Regen'] = {head="Runeist Bandeau +1"}
        sets.midcast['Stoneskin'] = {waist="Siegel Sash"}
        sets.midcast['Utsusemi: Ichi'] = {body="Futhark Coat", waist="Cetl Belt", feet="Iuitl Gaiters +1"}
        sets.midcast['Utsusemi: Ni'] = set_combine(sets.midcast['Utsusemi: Ichi'], {})
        sets.midcast.Recast = set_combine(sets.midcast['Utsusemi: Ichi'], {})

Phalanx, Regen and Stoneskin ARE Enhancing Magic Spells... and

function midcast(spell)
        if sets.midcast[spell.english] then
                equip(sets.midcast[spell.english])
        elseif sets.midcast[spell.type] then
                equip(sets.midcast[spell.type])
        elseif sets.midcast[spell.action_type] then
                equip(sets.midcast[spell.action_type])
        elseif sets.prefix == "/magic" then
                equip(sets.midcast.Recast)
        end
end

and with that code it will or should (havent tested) just pick one condition...
If you cast phalanx for ex.
if sets.midcast[spell.english] will kick and "elseif sets.prefix == "/magic" then" condition is true too... but my guess is Phalanx will take priority...

Phalanx spell.type is enhancing?... isnt spell.skill = Enhancing? the question is more that you have one midcast set w/ ['Enhancing Magic'], and no way to use it...

[Motenten]

If you cast phalanx for ex.
if sets.midcast[spell.english] will kick and "elseif sets.prefix == "/magic" then" condition is true too... but my guess is Phalanx will take priority...

Use of an if/elseif/else tree means that only one of the conditions will be executed. That's the entire point of the word 'else' -- an else/elseif condition is only run if the previous condition(s) were false. If Phalanx matches the first test, then all the remaining tests are skipped.

Phalanx spell.type is enhancing?... isnt spell.skill = Enhancing?

spell.type == "WhiteMagic", spell.skill == "Enhancing Magic"

So yes, the spell.type check should be changed to spell.skill, based on the fact that no sets are named after WhiteMagic/BlackMagic/etc.

In addition, the check for spell.action_type seems poorly considered. spell.action_type only has 4 possible values: Magic, Ability, Ranged Attack, and Item. There are no sets with any of those identifiers, so that test isn't doing anything. On the other hand, it would be better to test for spell.action_type == "Magic" than use the spell.prefix == "/magic" test (which is done incorrectly, by the way; it compares sets.prefix instead of spell.prefix).


Other than that, I don't see any immediate issues with the script.

[dlsmd]

i will say this only because it might help for the reasons below

if you do not plan on adding any gear to these
sets.midcast['Utsusemi: Ni'] = set_combine(sets.midcast['Utsusemi: Ichi'], {})
sets.midcast.Recast = set_combine(sets.midcast['Utsusemi: Ichi'], {})

then i recommend changing them to this
sets.midcast['Utsusemi: Ni'] = sets.midcast['Utsusemi: Ichi']
sets.midcast.Recast = sets.midcast['Utsusemi: Ichi']

[Motenten]

Or, actually, get rid of the Ichi and Ni sets entirely. They'll be caught in the default spell.action_type == "Magic" test, and that uses the same sets anyway, so....

[Sechs]

Was about to write one of my typical and annoying garrulous post, but Motenten saved you all from that
Yes, the meaning of having a single tree for those "IFs" is that they get executed in sequence. If Gearswap gets as further down the tree as to get to the "If action = enhancing magic" or "if action = magic" it means the condition "if action = phalanx/stoneskin/regen" already proved to be false.
As far as I could see it's working.
Minus the Error Motenten found, which I'm gonna fix, thanks!

As for the utsusemi sets, there actually is one different piece in that set, and it's Magoraga Beads (neck slot). I currently have nothing for the normal fast cast set in the neck slot, but just in case I manage to get a Jeweled collar/Orunmilla in the future I separated the two sets.

Edit:
Nevermind this last part, you were talking about the midcast one.
Yes at the moment they're perfectly identical. I left them separated in case we get some specific utusemi enhancing piece in the future but I don't see that happening very likely for any non NIN main job... so yeah, might as well use a generic midcast.Recast spell for all non previously defined magic, since the goal of such a set is just that to maximize the recast time reduction...

[theblackdeath]

im trying to make a rule for if i have paralysis to not use certain ja's the issue with what i have it is it wont ever let me use those ja's i only want these cause if i dont get specific it wont let me ranged attack or ws either any help would be greatly appreciated

if spell.english == "Berserk" or spell.english == "Warcry" or spell.english == "Eagle Eye Shot" or spell.english == "Scavenge" or spell.english == "Shadowbind" or spell.english == "Sharpshot" or spell.english == "Barrage" or spell.english == "Bounty Shot" or spell.english == "Decoy Shot" or spell.english == "Overkill" and buffactive.Amnesia or buffactive.Paralysis then
cancel_spell()
return
end

[dlsmd]

im trying to make a rule for if i have paralysis to not use certain ja's the issue with what i have it is it wont ever let me use those ja's i only want these cause if i dont get specific it wont let me ranged attack or ws either any help would be greatly appreciated

.....

try this

put this in "function get_sets()"

	Stop = {}
	Stop.spells = S{'Berserk','Warcry','Eagle Eye Shot','Scavenge','Shadowbind','Sharpshot','Barrage','Bounty Shot','Decoy Shot','Overkill'}
	Stop.spells.debuffs = S{'Amnesia','Paralysis'}

put this in "function precast(spell)" near the top

	if Stop.spells[spell.english] and Stop.spells.debuffs[buffactive] then
		cancel_spell()
		return
	end

with this if you decide to add or remove spells or buffs you can do it with ease

[Yamoman]

is there any way to equip a different jobprofile then the default nin.lua, brd.lua, etc? doin some testing with luas mixing and matching and would like to eqiup a different lua ie blutest.lua? i tried the equivalent spellcast version //gs profile bluetest but didnt work, oh, and would it also equip the corresponding gear sets? ie, bluetest and bluetest_gear? thx

[dlsmd]

as far as i know not yet

[Motenten]

try this

put this in "function get_sets()"

	Stop = {}
	Stop.spells = S{'Berserk','Warcry','Eagle Eye Shot','Scavenge','Shadowbind','Sharpshot','Barrage','Bounty Shot','Decoy Shot','Overkill'}
	Stop.spells.debuffs = S{'Amnesia','Paralysis'}

put this in "function precast(spell)" near the top

	if Stop.spells[spell.english] and Stop.spells.debuffs[buffactive] then
		cancel_spell()
		return
	end

with this if you decide to add or remove spells or buffs you can do it with ease

Not quite. You don't want Stop.spells[spell.english], you want Stop.spells:contains(spell.english). Also, Stop.spells.debuffs[buffactive] won't work. For this bit of code, it would be simpler just to check the individual buffs. So:

    if Stop.spells:contains(spell.english) and (buffactive.paralysis or buffactive.amnesia) then
        cancel_spell()
        return
    end

[dlsmd]

Not quite. You don't want Stop.spells[spell.english], you want Stop.spells:contains(spell.english).

why not it works for me on all the ones i use it on
like
Waltz.spells[spell.name]

or from my mage staff include
Typ.spells[spell.type]
or
Cure.spells[spell.english]

and others and some my lists are huge not small like his

[Yamoman]

Getting an error using the blu. lua on gearswap page, i change the BLueMagic to "Blue Magic" in the lua as stated in the previous posts but now getting this error message,
User file problem: c;windower4/addons/GearSwap/data/BLU:141: '<name>' expected near '"Blue Magic"'
This is line 141 in the lua.
sets.precast.FC."Blue Magic" = set_combine(sets.precast.FC, {body="Mavi Mintan +2"})
Can someone point out where i'm goin wrong, Thx in advance