Well I tried running your XML and its definitely outdated for 2.4. The rule itself is fine though as I used it in my BLM xml and everything worked out fine (granted I don't have the cape).
I think there is some tool that can auto-update your spellcast to meet 2.3/2.4 requirements in terms of syntax and such. However I'll post my spellcast for you to reference.
This code does in fact work for the cape:
Uhm speaking of updating the syntax (boolean in particular) you should probably get the new Sorc. Tonban line to replace. I know for sure the old Aikar one does not work anymore.Code:<if Advanced='"%SpellElement" = "%WeatherElement" OR "%SpellElement" = "%DayElement"'> <equip when="midcast"> <back lock="yes">Twilight Cape</back> </equip> </if>
Code:<if Advanced='(!((bool)strmatch("* x2","%Weather") AND "%WeatherElement" = "%SpellElement" AND "$%SpellElementObi" = "1") OR !("%WeatherElement" = "%spellElement")) AND ("%SpellElement" = "%DayElement" AND "$BLMAF2Pants" = "1") AND ("%skill"="ElementalMagic")'> <equip when="midcast"> <legs lock="yes">Sorcerer's Tonban</legs> </equip> </if>
XI Wiki


