c++ code help

[Skie]

I keep geting a error in line 25 saying identifier expected but i cant figure it out for the life of me, can anyone help me out. C++ code btw. Line 25 is at the end of the class. Similar google errors have said that its missing a simicolen or } but i dont see anything.

#ifndef Account
#define Account

#include <iostream>
#include <string>
#include <sstream>

using namespace std;

class Account {
    private:
    string ownerFirstName;
    string ownerLastName;
    float balance;
	float deposit;
	float withdraw;
    public:
    account();
    account(string f, string l, float b, float d, float w);
    void depositFunds(float d);
    void withdrawFunds(float w);
    float getBalance();
};
 
Account::Account() {
	ownerFirstName = Jhon;
    ownerLastName = Doe;
    balance = 2000;
}

Account::Account(string f, string l, float b, float w) {
    ownerFirstName = f;
    ownerLastName = l;
    balance = b;
	deposit = d;
	withdraw = w;
}

void Account::depositFunds(float d) {
	cout << "How much would you like to deposit today: ";
	cin >> deposit;
	int total = balance + deposit;
	cout << "You deposited", deposit," dollars." <<endl;
	cout << "Current Total is", total," dollars." <<endl;
	cout << " " << endl;
}

void Account::withdrawFunds(float w) {
	cout << "How much would you like to withdraw: ";
	cin >> withdraw;
	int total2 = balance - withdraw;
	cout << "You withdrew", withdraw, " dollars." <<endl;
	cout << " Current Total is", total2," dollars." <<endl;
	cout << " " << endl;
}

float Account::getBalance() {
	cout << "Current account balance is", balance," dollars." << endl;
	cout << " " << endl;
}

void main() {
    int choice = 0;
	while choice !=4; {
		cout << "What would you like to do"<< endl;
		cout << "1)  Display Current Account Balance" <<endl;
		cout << "2)  Deposit Money" <<endl;
		cout << "3)  Withdraw Money"<< endl;
		cout << "4)  Exit" << endl;
		cout << "Please make a selection: ";
		cin choice;
	}
    while choice !=5; {
		switch(choice) {
			case '1':
				cout << Account.getBalance();
			break;
			case '2':
				cout <<Account.depositFunds();
			break;
			case '3':
				cout <<Account.withdrawFunds();
        default:
				cout << "Thank you for using our serivice"<<endl;
				cout << "Goodbye" << endl;
		}
    }
 }

#endif

[Vic]

In the class Account, your constructor is lowercase, whereas when its defined, its uppercase.

[Purrrfect]

edit: i wuz rong

[Skie]

Well i've tried it both ways and it gives me 3 errors if i upper case the constructors.

Line 18: decleration terminated incorrectly
Line 19: ) expected
Line 25: idintifier expected

[Purrrfect]

Additionally, you need quotes around Jhon and Doe in your empty constructor.

And your constructor with parameters has 3 floats in the definition but only 2 later on where you declare it.

And all of your cout lines with variables in them need << instead of "text",variable,"text" "text"<<variable<<"text".

Cleaned up to the end but having trouble in the main(), doesn't look like there is an object of class Account created so nothing can store your data, and calling the member function fails it seems.

The deposit branch of the switch does not pass in a float either.

[Skie]

I suck at classes >< rather just use functions. Im not really sure how to make a object of accounts to hold the information

[Purrrfect]

Account variablename;

Oh, forgot to add, in your while statements, you have to ( ) around the condition.
while (stuff) {

[Skie]

Thanks i've edited all that weird that none of those proced errors. I'm still getting the same 3 errors but i have to go to work now till tonight, if i add the object you were talking about do you think it will fix those 3 errors?

#ifndef Account
#define Account

#include <iostream>
#include <string>
#include <sstream>

using namespace std;

class Account {
    private:
    string ownerFirstName;
    string ownerLastName;
    float balance;
	float deposit;
	float withdraw;
    public:
    Account();
    Account(string f, string l, float b, float d, float w);
    void depositFunds(float d);
    void withdrawFunds(float w);
    float getBalance();
};
 
Account::Account() {
	ownerFirstName = "Jhon";
    ownerLastName = "Doe";
    balance = 2000;
}

Account::Account(string f, string l,float d, float b, float w) {
    ownerFirstName = f;
    ownerLastName = l;
    balance = b;
	deposit = d;
	withdraw = w;
}

void Account::depositFunds(float d) {
	cout << "How much would you like to deposit today: ";
	cin >> deposit;
	int total = balance + deposit;
	cout << "You deposited"<< deposit<<" dollars." <<endl;
	cout << "Current Total is"<< total<<" dollars." <<endl;
	cout << " " << endl;
}

void Account::withdrawFunds(float w) {
	cout << "How much would you like to withdraw: ";
	cin >> withdraw;
	int total2 = balance - withdraw;
	cout << "You withdrew"<< withdraw<< " dollars." <<endl;
	cout << " Current Total is"<< total2<<" dollars." <<endl;
	cout << " " << endl;
}

float Account::getBalance() {
	cout << "Current account balance is"<< balance<<" dollars." << endl;
	cout << " " << endl;
}

void main() {
    int choice = 0;
	while (choice !=4) {
		cout << "What would you like to do"<< endl;
		cout << "1)  Display Current Account Balance" <<endl;
		cout << "2)  Deposit Money" <<endl;
		cout << "3)  Withdraw Money"<< endl;
		cout << "4)  Exit" << endl;
		cout << "Please make a selection: ";
		cin >> choice;
	}
    while (choice !=5) {
		switch(choice) {
			case '1':
				cout << Account.getBalance();
			break;
			case '2':
				cout <<Account.depositFunds();
			break;
			case '3':
				cout <<Account.withdrawFunds();
        default:
				cout << "Thank you for using our serivice"<<endl;
				cout << "Goodbye" << endl;
		}
    }
 }

#endif

[SnickySnacks]

No need for intros, that's an insult.

Your main problem is your #define Account then redefining it as a class a moment later.
Maybe I fixed a few more things to get it to run...

#include <iostream>
#include <string>
#include <sstream>

using namespace std;

class Account {
    private:
		string ownerFirstName;
		string ownerLastName;
		float balance;
		float deposit;
		float withdraw;
    public:
		Account();
		Account(string f, string l, float b, float d, float w);
		void depositFunds();
		void withdrawFunds();
		void getBalance();
};
 
Account::Account() {
	ownerFirstName = "Jhon";
    ownerLastName = "Doe";
    balance = 2000;
}

Account::Account(string f, string l,float d, float b, float w) {
    ownerFirstName = f;
    ownerLastName = l;
    balance = b;
	deposit = d;
	withdraw = w;
}

void Account::depositFunds() {
	cout << "How much would you like to deposit today: ";
	cin >> deposit;
	balance+=deposit;
	cout << "You deposited "<< deposit<<" dollars." <<endl;
	getBalance();
}

void Account::withdrawFunds() {
	cout << "How much would you like to withdraw: ";
	cin >> withdraw;
	balance-=withdraw;
	cout << "You withdrew "<< withdraw<< " dollars." <<endl;
	getBalance();
}

void Account::getBalance() {
	cout << "Current account balance is "<< balance<<" dollars." << endl;
	cout << " " << endl;
}

void main() 
{
	Account MyAccount;
    int choice = 0;
	do
	{
		cout << "What would you like to do"<< endl;
		cout << "1)  Display Current Account Balance" <<endl;
		cout << "2)  Deposit Money" <<endl;
		cout << "3)  Withdraw Money"<< endl;
		cout << "4)  Exit" << endl;
		cout << "Please make a selection: ";
		cin >> choice;
		switch(choice) {
			case 1:
				MyAccount.getBalance();
				break;
			case 2:
				MyAccount.depositFunds();
				break;
			case 3:
				MyAccount.withdrawFunds();
				break;
			case 4:
				cout << "Thank you for using our serivice"<<endl;
				cout << "Goodbye" << endl;	
				break;
			default:
				cout << "Invalid selection"<<endl;
				break;
		}
    }while(choice!=4);
 }

[nitsuj]

The identifier expected error is almost definitely because you left out the quotes.

Always remember:

"awesome" = a string, char *, or char[]

'a' = a char

awesome = a variable.

So if you said:

iam = awesome;

it would set the value of "iam" to the value of "awesome", but I didn't define "awesome" so it would error.

But this:

awesome = "awesome";
iam = awesome;

and

iam = "awesome"

would both work

Of course this is pseudo code, but you should get the point.

[Purrrfect]

I like snickysnacks' rendition, only issue is the parameter list flip flops b and d in the constructor definition/declaration. That would be an interesting thing to figure out at runtime lol.

[Skie]

trying to go off example codes and thats how the example did it with their class. D is suposta represent deposit, b balance

[SnickySnacks]

he means that in your constructor you have it one way but in the actual function it's reversed. Would be very confusing if you were using the constructor to make the function call since the actual function would be putting things in the wrong order when it was called:

Account(string f, string l, float b, float d, float w);
Account::Account(string f, string l,float d, float b, float w) {

[nitsuj]

trying to go off example codes and thats how the example did it with their class. D is suposta represent deposit, b balance

Skie-

One important thing to note and something I've noticed about most good programmers...

Proper spelling and capitalization is almost ALWAYS a sign of a good programmer.

int foo = 0;

int bar = Foo + 3;

... won't compile, simply due to a wrong capitalization. And when you start having variables like tempWeaponDPSCalculationValue; or something, capitalization is going to be a very important thing to master.

Take the time to make your english (or whatever your native language is) a bit more concise and you'll start to see that carry over into your programming.

Programming is a VERY specific skill to have. You must remember your semicolons at the end of every line, you must follow proper indention and syntax for all your loops/if statements, and you must spell the functions and macros EXACTLY right otherwise your code won't compile.

Also, the worst part, you'll spend a ton of time staring a simple code block trying to figure out why it won't compile only to realize you typed "Deposit" instead of "deposit" and you'll kick yourself

Good luck!

[Naver]

At least with Visual Studios, ctrl+space is a godsend.

[viperlasson]

I just started using Eclipse for java and it checks for errors on the fly, and gives you ways of fixing it, which I thought was amazing.

[Kaelan?]

Visual Assist is an incredibly useful tool to have for this kind of thing.

[nitsuj]

Visual Assist is an incredibly useful tool to have for this kind of thing.

this x 1000000000

I cannot code in Visual Studio without Visual Assist anymore.

[Eliseos]

I just started using Eclipse for java and it checks for errors on the fly, and gives you ways of fixing it, which I thought was amazing.

Just wait until you use the professional edition of intelliJ. I don't know how I code in anything else (like a putty console window for school).

[nitsuj]

Just wait until you use the professional edition of intelliJ. I don't know how I code in anything else (like a putty console window for school).

intellij is sweeeeeeet for java.